Bug 157527

Summary: bmalloc should automatically disable itself when ThreadSanitizer is used
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: bmallocAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ggaren, mark.lam, mcatanzaro, msaboff
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=157462
Attachments:
Description Flags
Patch v1
none
Patch v2 none

David Kilzer (:ddkilzer)
Reported 2016-05-10 10:51:51 PDT
When ThreadSanitizer is loaded at runtime, bmalloc should disable itself, much like it does for AddressSanitizer. This prevents false positive reports like the one in Bug 157462.
Attachments
Patch v1 (2.69 KB, patch)
2016-05-10 11:14 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.69 KB, patch)
2016-05-10 14:13 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2016-05-10 11:14:42 PDT
Created attachment 278515 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2016-05-10 14:13:04 PDT
Created attachment 278529 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 3 2016-05-10 14:13:35 PDT
Comment on attachment 278515 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=278515&action=review > Source/bmalloc/bmalloc/Environment.cpp:121 > - if (isASanEnabled()) > + if (isSantizerEnabled()) Spelling is hard.
WebKit Commit Bot
Comment 4 2016-05-10 16:46:22 PDT
Comment on attachment 278529 [details] Patch v2 Clearing flags on attachment: 278529 Committed r200654: <http://trac.webkit.org/changeset/200654>
WebKit Commit Bot
Comment 5 2016-05-10 16:46:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.