Bug 157418

Summary: [Win] Skip failing INTL test.
Product: WebKit Reporter: peavo
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, lforschler, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

peavo
Reported 2016-05-06 02:39:24 PDT
Temporarily skip js/string-localeCompare.html, because AppleWin currently does not have INTL enabled.
Attachments
Patch (1.74 KB, patch)
2016-05-06 02:47 PDT, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2016-05-06 02:47:52 PDT
Created attachment 278248 [details] Patch
Alex Christensen
Comment 2 2016-05-06 06:46:36 PDT
These shouldn't both be necessary
Csaba Osztrogonác
Comment 3 2016-05-06 07:30:16 PDT
(In reply to comment #2) > These shouldn't both be necessary Why not? TestExpectations is used by run-webkit-tests, the "//@ skip" magic is used by run-javascriptcore-tests. The proposed patch is the proper way to skip a LayoutTests/js test.
Alex Christensen
Comment 4 2016-05-06 21:04:01 PDT
Comment on attachment 278248 [details] Patch Sure enough
WebKit Commit Bot
Comment 5 2016-05-06 21:25:06 PDT
Comment on attachment 278248 [details] Patch Clearing flags on attachment: 278248 Committed r200537: <http://trac.webkit.org/changeset/200537>
WebKit Commit Bot
Comment 6 2016-05-06 21:25:10 PDT
All reviewed patches have been landed. Closing bug.
peavo
Comment 7 2016-05-09 19:33:57 PDT
Thanks for reviewing!
Note You need to log in before you can comment on or make changes to this bug.