Bug 157405 – Don't use DiskCache for media resource loads

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Don't use DiskCache for media resource loads

[Alex Christensen]

Created attachment 278217 [details]
Patch

[WebKit Commit Bot]

Attachment 278217 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/ResourceRequestBase.h:153:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 278217 [details]
Patch

Clearing flags on attachment: 278217

Committed r200578: <http://trac.webkit.org/changeset/200578>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Carlos Garcia Campos]

Comment on attachment 278217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278217&action=review

> Source/WebCore/loader/MediaResourceLoader.cpp:67
> +    auto cachingPolicy = options & LoadOption::DisallowCaching ? CachingPolicy::DisallowCaching : CachingPolicy::AllowCaching;

I'm confused. This is not about disk cache, but about memory cache, right? Why is this added as an option? Why not passing CachingPolicy::DisallowCaching unconditionally for media loads? Looking at the code below we disallow caching in the disk cache always for media requests.

[Alex Christensen]

(In reply to comment #5)
> Comment on attachment 278217 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278217&action=review
> 
> > Source/WebCore/loader/MediaResourceLoader.cpp:67
> > +    auto cachingPolicy = options & LoadOption::DisallowCaching ? CachingPolicy::DisallowCaching : CachingPolicy::AllowCaching;
> 
> I'm confused. This is not about disk cache, but about memory cache, right?
> Why is this added as an option? Why not passing
> CachingPolicy::DisallowCaching unconditionally for media loads? Looking at
> the code below we disallow caching in the disk cache always for media
> requests.

This just translates one place where we store the caching policy to another place where we store the same policy.  These are indeed about the memory cache, and we did it this way to not touch GTK/GStreamer's caching policy.  The disk cache is disabled by the uses of WebCore::ResourceRequest::Requester::Media in NetworkCache.cpp.
We do not want to use WebKit's caches right now because we are using AVFoundation's caches.