Bug 157391 – [GTK] Add CSS Grid Layout as experimental feature

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Manuel Rego Casasnovas]

Now that we've a runtime feature for CSS Grid Layout again (bug #157134),
we can recover the old patch to enable it from an env variable (bug #127089).

[Manuel Rego Casasnovas]

Created attachment 278194 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 278194 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278194&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:157
> +    ExperimentalFeatures features;

I usually prefer to leave one blank line above variable declarations, especially when they're not initialized. It's easier to read IMO.

[WebKit Commit Bot]

Comment on attachment 278194 [details]
Patch

Clearing flags on attachment: 278194

Committed r200497: <http://trac.webkit.org/changeset/200497>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

The compile flag is still off by default. I don't think the runtime flag serves any useful purpose if this functionality is compiled out by default. Presumably, you would only change the build flags if you really want to test CSS grid layout, so it's currently just another obstacle to overcome.

I think we should flip ENABLE_CSS_GRID_LAYOUT to be on by default.

[Manuel Rego Casasnovas]

(In reply to comment #6)
> The compile flag is still off by default. I don't think the runtime flag
> serves any useful purpose if this functionality is compiled out by default.
> Presumably, you would only change the build flags if you really want to test
> CSS grid layout, so it's currently just another obstacle to overcome.
> 
> I think we should flip ENABLE_CSS_GRID_LAYOUT to be on by default.

Yeah I agree, at least for WebKitGTK+ we want to build it by default (and keep the runtime flag disabled by default).

Should we modify Source/cmake/WebKitFeatures.cmake to make it ON by default?
Or the change should go somewhere else?

[Michael Catanzaro]

(In reply to comment #7)
> Should we modify Source/cmake/WebKitFeatures.cmake to make it ON by default?

Yes.

Also in FeatureList.pm if it's not already.