Bug 157368

Summary: Web Inspector: Console is unresponsive for >10 seconds when it tries to render 10,000 messages
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 142011    
Attachments:
Description Flags
[HTML] Reduction
none
Patch none

Nikita Vasilyev
Reported 2016-05-04 17:35:56 PDT
Steps: 1. Open the attached reduction. 2. Inspect <body>, make sure split console is closed 3. Open Console tab or press Esc to open the split console Expected: Inspector UI should be reasonable responsive. Actual: Inspector UI freezes for 10-15 seconds. Notes: After http://trac.webkit.org/changeset/200401, console messages get rendered only when the console shows up. Firing console.log-s when we're on, say, Elements tab, don't result in messages being rendered right away. This may create a case when we need to render thousands of console messages upon opening the console for the first time. Ideally, we'd want to render only messages in the viewport first. For now, I suggest to limit how many messages we render per requestAnimationFrame, to keep the UI responsive.
Attachments
[HTML] Reduction (197 bytes, text/html)
2016-05-04 17:39 PDT, Nikita Vasilyev 		no flags
Details
Patch (2.55 KB, patch)
2016-05-04 17:49 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-04 17:36:34 PDT
<rdar://problem/26103657>
Nikita Vasilyev
Comment 2 2016-05-04 17:39:02 PDT
Created attachment 278147 [details] [HTML] Reduction
Nikita Vasilyev
Comment 3 2016-05-04 17:49:43 PDT
Created attachment 278148 [details] Patch
Nikita Vasilyev
Comment 4 2016-05-04 17:51:46 PDT
Comment on attachment 278148 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278148&action=review > Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:288 > + const maxMessagesPerFrame = 100; Adding the first 100 messages to the DOM takes ~20ms (1/50 of a second). Adding 10,001st to 10,100th message takes >250ms (1/4 of a second). I think 100 is a reasonable number here.
WebKit Commit Bot
Comment 5 2016-05-05 13:11:40 PDT
Comment on attachment 278148 [details] Patch Clearing flags on attachment: 278148 Committed r200471: <http://trac.webkit.org/changeset/200471>
WebKit Commit Bot
Comment 6 2016-05-05 13:11:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.