Bug 157356

Summary:

REGRESSION (r200401): Web Inspector: TypeError: undefined is not an object (evaluating 'messageElement.classList')

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Nikita Vasilyev

Reported 2016-05-04 13:54:16 PDT

[Error] Uncaught exception in inspector page while handling event Page.frameNavigated TypeError: undefined is not an object (evaluating 'messageElement.classList') (anonymous function) — LogContentView.js:688 forEach _filterMessageElements — LogContentView.js:679 _reappendProvisionalMessages — LogContentView.js:976 _sessionStarted — LogContentView.js:287 dispatch — Object.js:161 dispatchEventToListeners — Object.js:168 _mainResourceDidChange — LogManager.js:118 dispatch — Object.js:161 dispatchEventToListeners — Object.js:176 _dispatchMainResourceDidChangeEvent — Frame.js:497 commitProvisionalLoad — Frame.js:140 frameDidNavigate — FrameResourceManager.js:105 frameNavigated — PageObserver.js:42 dispatchEvent — InspectorBackend.js:448 _dispatchEvent — InspectorBackend.js:342 dispatch — InspectorBackend.js:151 dispatchNextQueuedMessageFromBackend — MessageDispatcher.js:42 _dispatchEvent (InspectorBackend.js:344) dispatch (InspectorBackend.js:151) dispatchNextQueuedMessageFromBackend (MessageDispatcher.js:42)

Attachments
Patch (1.80 KB, patch) 2016-05-04 15:41 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-05-04 13:55:14 PDT

<rdar://problem/26097424>

Nikita Vasilyev

Comment 2 2016-05-04 13:59:13 PDT

https://github.com/WebKit/webkit/blob/2f5ab3dcd0f5d3b6bc36bf46582cee8f76226db4/Source/WebInspectorUI/UserInterface/Views/LogContentView.js#L976 messageView.element doesn't exist when the console hasn't been shown yet. Now that I moved _filterMessageElements to didAppendConsoleMessageView, we should be able to just remove it here.

Nikita Vasilyev

Comment 3 2016-05-04 15:41:11 PDT

Created attachment 278135 [details] Patch

WebKit Commit Bot

Comment 4 2016-05-04 16:35:48 PDT

Comment on attachment 278135 [details] Patch Clearing flags on attachment: 278135 Committed r200439: <http://trac.webkit.org/changeset/200439>

WebKit Commit Bot

Comment 5 2016-05-04 16:35:53 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.