Bug 157317

Summary: Improve Symbol() to string coercion error message
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Joseph Pecoraro
Reported 2016-05-03 12:10:39 PDT
* SUMMARY Improve Symbol() to string error message. I'm not sure I agree with he "can't convert to a string" when Symbol().toString() at least provides a string. But still, our error message is super cryptic and needs to be improved. * Safari js> "" + Symbol() TypeError: Type error * Chrome js> "" + Symbol() TypeError: Cannot convert a Symbol value to a string * Firefox js> "" + Symbol() TypeError: can't convert symbol to string * Edge js> "" + Symbol() Object doesn't support property or method 'ToString'
Attachments
Patch (35.90 KB, patch)
2016-05-03 15:04 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-05-03 14:54:52 PDT
Lol, that's a pretty bad error message. I think it would be worthwhile at some point to vet all of our error messages and make them better.
Yusuke Suzuki
Comment 2 2016-05-03 15:04:46 PDT
Created attachment 278031 [details] Patch
Yusuke Suzuki
Comment 3 2016-05-03 15:52:32 PDT
Comment on attachment 278031 [details] Patch Thanks!
WebKit Commit Bot
Comment 4 2016-05-03 18:21:02 PDT
Comment on attachment 278031 [details] Patch Clearing flags on attachment: 278031 Committed r200402: <http://trac.webkit.org/changeset/200402>
WebKit Commit Bot
Comment 5 2016-05-03 18:21:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.