Bug 157300

Summary: Eliminate PassRefPtr conversion from ConsoleObject
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix timothy: review+, commit-queue: commit-queue-

Joseph Pecoraro
Reported 2016-05-02 21:24:02 PDT
* SUMMARY Eliminate PassRefPtr conversion from ConsoleObject No need for this here, the callers take a RefPtr<T>&&.
Attachments
[PATCH] Proposed Fix (6.01 KB, patch)
2016-05-02 21:25 PDT, Joseph Pecoraro 		timothy: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-05-02 21:25:53 PDT
Created attachment 277975 [details] [PATCH] Proposed Fix Might not apply until other patches land.
WebKit Commit Bot
Comment 2 2016-05-03 08:23:53 PDT
Comment on attachment 277975 [details] [PATCH] Proposed Fix Rejecting attachment 277975 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 277975, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: FAILED at 209. Hunk #8 succeeded at 217 (offset -3 lines). Hunk #9 succeeded at 322 (offset -3 lines). Hunk #10 succeeded at 333 (offset -3 lines). Hunk #11 succeeded at 344 (offset -3 lines). Hunk #12 succeeded at 355 (offset -3 lines). 1 out of 12 hunks FAILED -- saving rejects to file Source/JavaScriptCore/runtime/ConsoleObject.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1261259
Joseph Pecoraro
Comment 3 2016-05-03 11:41:23 PDT
<http://trac.webkit.org/changeset/200384>
Note You need to log in before you can comment on or make changes to this bug.