Summary: | Web Inspector: console.assert should do far less work when the assertion is true | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, nvasilyev, saam, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-05-02 20:50:36 PDT
Created attachment 277972 [details]
[PATCH] Proposed Fix
We could make assert an intrinsic in the future, but I'm not sure it really needs it. This alone was a 10x speedup.
Comment on attachment 277972 [details]
[PATCH] Proposed Fix
Nice!
Comment on attachment 277972 [details] [PATCH] Proposed Fix Clearing flags on attachment: 277972 Committed r200371: <http://trac.webkit.org/changeset/200371> All reviewed patches have been landed. Closing bug. Comment on attachment 277972 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=277972&action=review > Source/JavaScriptCore/runtime/ConsoleClient.h:53 > + void assertion(ExecState*, RefPtr<Inspector::ScriptArguments>&&); The right name for this seems to be "assertionFailed". Longer term, really puzzled about the fact that ScriptArguments is a reference counted object. |