Bug 157279

Summary: Modernize HTMLConstructionSite
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, gyuyoung.kim, kangil.han, koivisto, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2016-05-02 14:14:02 PDT 
Modernize HTMLConstructionSite.
Comment 1 Chris Dumez 2016-05-02 14:16:26 PDT 
Created attachment 277933 [details]
Patch
Comment 2 Alex Christensen 2016-05-02 15:09:13 PDT 
Comment on attachment 277933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277933&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.cpp:723
> +            return firstUnopenElementIndex < m_activeFormattingElements.size() ? firstUnopenElementIndex : Optional<unsigned>(Nullopt);

Doesn't just Nullopt work?

> Source/WebCore/html/parser/HTMLFormattingElementList.h:53
> +        { }

Don't we like these on different lines in this case?

> Source/WebCore/html/parser/HTMLFormattingElementList.h:56
> +        { }

ditto

> Source/WebCore/html/parser/HTMLFormattingElementList.h:83
> +        { }

ditto
Comment 3 Chris Dumez 2016-05-02 15:15:20 PDT 
Comment on attachment 277933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277933&action=review

>> Source/WebCore/html/parser/HTMLConstructionSite.cpp:723
>> +            return firstUnopenElementIndex < m_activeFormattingElements.size() ? firstUnopenElementIndex : Optional<unsigned>(Nullopt);
> 
> Doesn't just Nullopt work?

No, it did not build.
Comment 4 Chris Dumez 2016-05-02 15:16:41 PDT 
Created attachment 277940 [details]
Patch
Comment 5 Chris Dumez 2016-05-02 15:17:29 PDT 
Comment on attachment 277940 [details]
Patch

Clearing flags on attachment: 277940

Committed r200340: <http://trac.webkit.org/changeset/200340>
Comment 6 Chris Dumez 2016-05-02 15:17:36 PDT 
All reviewed patches have been landed.  Closing bug.