Bug 157279

Summary: Modernize HTMLConstructionSite
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, gyuyoung.kim, kangil.han, koivisto, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-05-02 14:14:02 PDT
Modernize HTMLConstructionSite.
Attachments
Patch (102.40 KB, patch)
2016-05-02 14:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (102.36 KB, patch)
2016-05-02 15:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-05-02 14:16:26 PDT
Created attachment 277933 [details] Patch
Alex Christensen
Comment 2 2016-05-02 15:09:13 PDT
Comment on attachment 277933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277933&action=review > Source/WebCore/html/parser/HTMLConstructionSite.cpp:723 > + return firstUnopenElementIndex < m_activeFormattingElements.size() ? firstUnopenElementIndex : Optional<unsigned>(Nullopt); Doesn't just Nullopt work? > Source/WebCore/html/parser/HTMLFormattingElementList.h:53 > + { } Don't we like these on different lines in this case? > Source/WebCore/html/parser/HTMLFormattingElementList.h:56 > + { } ditto > Source/WebCore/html/parser/HTMLFormattingElementList.h:83 > + { } ditto
Chris Dumez
Comment 3 2016-05-02 15:15:20 PDT
Comment on attachment 277933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277933&action=review >> Source/WebCore/html/parser/HTMLConstructionSite.cpp:723 >> + return firstUnopenElementIndex < m_activeFormattingElements.size() ? firstUnopenElementIndex : Optional<unsigned>(Nullopt); > > Doesn't just Nullopt work? No, it did not build.
Chris Dumez
Comment 4 2016-05-02 15:16:41 PDT
Created attachment 277940 [details] Patch
Chris Dumez
Comment 5 2016-05-02 15:17:29 PDT
Comment on attachment 277940 [details] Patch Clearing flags on attachment: 277940 Committed r200340: <http://trac.webkit.org/changeset/200340>
Chris Dumez
Comment 6 2016-05-02 15:17:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.