Bug 157233

Summary: Node.prototype.rootNode is not Web compatible
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eoconnor, esprehn+autocc, kangil.han, koivisto, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Removes the method none

Ryosuke Niwa
Reported 2016-04-30 02:27:29 PDT
Turns out that adding `rootNode` to `Node.prototype` break a bunch of websites. We need to rename this to something else (https://github.com/whatwg/dom/issues/241). Meanwhile, unbreak the Web by removing this property from Node's prototype for now. <rdar://problem/25547767> <rdar://problem/25766328>
Attachments
Removes the method (16.94 KB, patch)
2016-04-30 02:58 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-04-30 02:58:18 PDT
Created attachment 277806 [details] Removes the method
Ryosuke Niwa
Comment 2 2016-04-30 02:58:39 PDT
Note that C++ side's Node::rootNode is still used internally.
Chris Dumez
Comment 3 2016-04-30 08:00:04 PDT
Comment on attachment 277806 [details] Removes the method View in context: https://bugs.webkit.org/attachment.cgi?id=277806&action=review r=me > Source/WebCore/dom/Node.idl:-64 > - readonly attribute Node rootNode; Shouldn't it have been RuntimeEnabled?
Ryosuke Niwa
Comment 4 2016-04-30 14:12:18 PDT
Blink had a similar report as well: https://bugs.chromium.org/p/chromium/issues/detail?id=600950
WebKit Commit Bot
Comment 5 2016-04-30 14:58:09 PDT
Comment on attachment 277806 [details] Removes the method Clearing flags on attachment: 277806 Committed r200297: <http://trac.webkit.org/changeset/200297>
WebKit Commit Bot
Comment 6 2016-04-30 14:58:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.