Bug 157205

Summary:

Do not reuse cache entries with conditional headers

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, japhet, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Patch	cdumez: review+, cdumez: commit-queue-

Alex Christensen

Reported 2016-04-29 15:01:05 PDT

Do not reuse cache entries with conditional headers

Attachments
Patch (4.18 KB, patch) 2016-04-29 15:15 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (936.92 KB, application/zip) 2016-04-29 16:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (864.66 KB, application/zip) 2016-04-29 16:17 PDT, Build Bot	no flags	Details
Patch (5.47 KB, patch) 2016-04-29 17:51 PDT, Alex Christensen	cdumez: review+ cdumez: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2016-04-29 15:15:48 PDT

Created attachment 277735 [details] Patch

Build Bot

Comment 2 2016-04-29 16:00:12 PDT

Comment on attachment 277735 [details] Patch Attachment 277735 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1241663 New failing tests: http/tests/xmlhttprequest/if-modified-since-0.html

Build Bot

Comment 3 2016-04-29 16:00:15 PDT

Created attachment 277746 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-04-29 16:17:01 PDT

Comment on attachment 277735 [details] Patch Attachment 277735 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1241678 New failing tests: http/tests/xmlhttprequest/if-modified-since-0.html

Build Bot

Comment 5 2016-04-29 16:17:09 PDT

Created attachment 277751 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Alex Christensen

Comment 6 2016-04-29 17:51:08 PDT

Created attachment 277768 [details] Patch

Chris Dumez

Comment 7 2016-04-29 19:07:21 PDT

Comment on attachment 277768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277768&action=review r=me with comment. > LayoutTests/http/tests/xmlhttprequest/if-modified-since-0.html:15 > + alert(req2.status + " " + req2.responseText + " " + internals.xhrResponseSource(req2)); If the test were to fail, it would print something like: ALERT: 200 PASS MemoryCache Quite confusing as this would be a failure. I think this test should only display PASS if the source is Network. > LayoutTests/http/tests/xmlhttprequest/if-modified-since-0.html:16 > + if (window.testRunner) indentation is bad

Alex Christensen

Comment 8 2016-05-02 11:05:29 PDT

http://trac.webkit.org/changeset/200326

Note You need to log in before you can comment on or make changes to this bug.