Bug 157182

Summary: r200069 fails to link on darwin/gtk -- missing symbols
Product: WebKit Reporter: Jeremy Huddleston Sequoia <jeremyhu>
Component: ANGLEAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
build log (bzip2 compressed)
none
0001-GTK-Fix-build-failure-introduced-by-r199738.patch none

Jeremy Huddleston Sequoia
Reported 2016-04-29 09:15:01 PDT
Recent trunk (r200069) fails to link libwebkit2gtk-4.0.dylib due to undefined symbols for TranslatorHLSL.cpp.o: Undefined symbols for architecture x86_64: "RemoveDynamicIndexing(TIntermNode*, unsigned int*, TSymbolTable const&, int)", referenced from: TranslatorHLSL::translate(TIntermNode*, int) in libANGLESupport.a(TranslatorHLSL.cpp.o) "UnfoldShortCircuitToIf(TIntermNode*, unsigned int*)", referenced from: TranslatorHLSL::translate(TIntermNode*, int) in libANGLESupport.a(TranslatorHLSL.cpp.o) "SeparateExpressionsReturningArrays(TIntermNode*, unsigned int*)", referenced from: TranslatorHLSL::translate(TIntermNode*, int) in libANGLESupport.a(TranslatorHLSL.cpp.o) ld: symbol(s) not found for architecture x86_64
Attachments
build log (bzip2 compressed) (904.56 KB, application/octet-stream)
2016-04-29 09:23 PDT, Jeremy Huddleston Sequoia 		no flags
Details
0001-GTK-Fix-build-failure-introduced-by-r199738.patch (2.95 KB, patch)
2016-04-29 09:47 PDT, Jeremy Huddleston Sequoia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Huddleston Sequoia
Comment 1 2016-04-29 09:23:22 PDT
Created attachment 277706 [details] build log (bzip2 compressed)
Jeremy Huddleston Sequoia
Comment 2 2016-04-29 09:35:18 PDT
It looks like you forgot to add the new files to ANGLESupport in r199738
Jeremy Huddleston Sequoia
Comment 3 2016-04-29 09:47:35 PDT
Created attachment 277709 [details] 0001-GTK-Fix-build-failure-introduced-by-r199738.patch
Alex Christensen
Comment 4 2016-04-29 10:02:54 PDT
Comment on attachment 277709 [details] 0001-GTK-Fix-build-failure-introduced-by-r199738.patch It's strange that gtk on linux doesn't need this. Thanks for the fix, though.
WebKit Commit Bot
Comment 5 2016-04-29 10:19:38 PDT
Comment on attachment 277709 [details] 0001-GTK-Fix-build-failure-introduced-by-r199738.patch Clearing flags on attachment: 277709 Committed r200250: <http://trac.webkit.org/changeset/200250>
WebKit Commit Bot
Comment 6 2016-04-29 10:19:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.