Bug 157182

Summary: r200069 fails to link on darwin/gtk -- missing symbols
Product: WebKit Reporter: Jeremy Huddleston Sequoia <jeremyhu>
Component: ANGLEAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
build log (bzip2 compressed)
none
0001-GTK-Fix-build-failure-introduced-by-r199738.patch none

Description Jeremy Huddleston Sequoia 2016-04-29 09:15:01 PDT 
Recent trunk (r200069) fails to link libwebkit2gtk-4.0.dylib due to undefined symbols for TranslatorHLSL.cpp.o:

Undefined symbols for architecture x86_64:
  "RemoveDynamicIndexing(TIntermNode*, unsigned int*, TSymbolTable const&, int)", referenced from:
      TranslatorHLSL::translate(TIntermNode*, int) in libANGLESupport.a(TranslatorHLSL.cpp.o)
  "UnfoldShortCircuitToIf(TIntermNode*, unsigned int*)", referenced from:
      TranslatorHLSL::translate(TIntermNode*, int) in libANGLESupport.a(TranslatorHLSL.cpp.o)
  "SeparateExpressionsReturningArrays(TIntermNode*, unsigned int*)", referenced from:
      TranslatorHLSL::translate(TIntermNode*, int) in libANGLESupport.a(TranslatorHLSL.cpp.o)
ld: symbol(s) not found for architecture x86_64
Comment 1 Jeremy Huddleston Sequoia 2016-04-29 09:23:22 PDT 
Created attachment 277706 [details]
build log (bzip2 compressed)
Comment 2 Jeremy Huddleston Sequoia 2016-04-29 09:35:18 PDT 
It looks like you forgot to add the new files to ANGLESupport in r199738
Comment 3 Jeremy Huddleston Sequoia 2016-04-29 09:47:35 PDT 
Created attachment 277709 [details]
0001-GTK-Fix-build-failure-introduced-by-r199738.patch
Comment 4 Alex Christensen 2016-04-29 10:02:54 PDT 
Comment on attachment 277709 [details]
0001-GTK-Fix-build-failure-introduced-by-r199738.patch

It's strange that gtk on linux doesn't need this.  Thanks for the fix, though.
Comment 5 WebKit Commit Bot 2016-04-29 10:19:38 PDT 
Comment on attachment 277709 [details]
0001-GTK-Fix-build-failure-introduced-by-r199738.patch

Clearing flags on attachment: 277709

Committed r200250: <http://trac.webkit.org/changeset/200250>
Comment 6 WebKit Commit Bot 2016-04-29 10:19:42 PDT 
All reviewed patches have been landed.  Closing bug.