Bug 157165

Summary:

[CMake] ENABLE_WEBKIT OFF remained, unnecessary code

Product:

WebKit

Reporter:

keunseob.kim

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

lucas.de.marchi, ossy

Priority:

Version:

WebKit Local Build

Hardware:

OS:

Linux

Attachments:

Description	Flags
remove unnecessary code related to enable_webkit	none
Patch	ossy: review-

keunseob.kim

Reported 2016-04-29 00:15:38 PDT

Remove unnecessary script code in Source/cmake/OptionsEfl.cmake

Attachments
remove unnecessary code related to enable_webkit (648.09 KB, patch) 2016-04-29 00:40 PDT, keunseob.kim	no flags	Details Formatted Diff Diff
Patch (19.37 KB, patch) 2016-04-29 00:51 PDT, keunseob.kim	ossy: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

keunseob.kim

Comment 1 2016-04-29 00:40:58 PDT

Created attachment 277682 [details] remove unnecessary code related to enable_webkit

keunseob.kim

Comment 2 2016-04-29 00:51:56 PDT

Csaba Osztrogonác

Comment 3 2016-04-29 03:07:37 PDT

Comment on attachment 277683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277683&action=review > Source/cmake/OptionsEfl.cmake:-6 > -set(ENABLE_WEBKIT OFF) EFL port doesn't build the old WebKit1, that's why we have to set this option to OFF.

Note You need to log in before you can comment on or make changes to this bug.