Bug 157145

Summary:

imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on some bots

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Tools / Tests

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, lforschler, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

136452

Bug Blocks:

Attachments:

Description	Flags
Patch for landing	none

youenn fablet

Reported 2016-04-28 11:18:54 PDT

imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on some bots

Attachments
Patch for landing (1.57 KB, patch) 2016-04-28 11:22 PDT, youenn fablet	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2016-04-28 11:22:11 PDT

Created attachment 277636 [details] Patch for landing

WebKit Commit Bot

Comment 2 2016-04-28 12:35:02 PDT

Comment on attachment 277636 [details] Patch for landing Clearing flags on attachment: 277636 Committed r200204: <http://trac.webkit.org/changeset/200204>

WebKit Commit Bot

Comment 3 2016-04-28 12:35:05 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 4 2016-04-28 13:45:26 PDT

*** Bug 157144 has been marked as a duplicate of this bug. ***

Alexey Proskuryakov

Comment 5 2016-04-28 19:53:21 PDT

Re-opening, because the test was only marked as flaky, not fixed.

Daniel Bates

Comment 6 2017-04-25 13:26:31 PDT

(In reply to youenn fablet from comment #0) > imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on > some bots I am unclear how this test could have passed on any bot. At the time of writing, WebCore does not honor X-Content-Type-Options: nosniff in the HTTP response for a stylesheet. Once we add such support in bug #136452 then this test will pass on platforms that ENABLE(NOSNIFF) and whose networking stack supports nosniff.

Daniel Bates

Comment 7 2017-04-25 13:27:54 PDT

Fixed in <http://trac.webkit.org/changeset/215753> (bug #136452).

youenn fablet

Comment 8 2017-04-25 13:53:29 PDT

(In reply to Daniel Bates from comment #6) > (In reply to youenn fablet from comment #0) > > imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on > > some bots > > I am unclear how this test could have passed on any bot. At the time of > writing, WebCore does not honor X-Content-Type-Options: nosniff in the HTTP > response for a stylesheet. Once we add such support in bug #136452 then this > test will pass on platforms that ENABLE(NOSNIFF) and whose networking stack > supports nosniff. Failing is meant in terms of -expected.txt equality, not in terms of all tests outputting PASS.

Note You need to log in before you can comment on or make changes to this bug.