Bug 157145

Summary: imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on some bots
Product: WebKit Reporter: youenn fablet <youennf>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, lforschler, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 136452    
Bug Blocks:    
Attachments:
Description Flags
Patch for landing none

Description youenn fablet 2016-04-28 11:18:54 PDT
imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on some bots
Comment 1 youenn fablet 2016-04-28 11:22:11 PDT
Created attachment 277636 [details]
Patch for landing
Comment 2 WebKit Commit Bot 2016-04-28 12:35:02 PDT
Comment on attachment 277636 [details]
Patch for landing

Clearing flags on attachment: 277636

Committed r200204: <http://trac.webkit.org/changeset/200204>
Comment 3 WebKit Commit Bot 2016-04-28 12:35:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Ryan Haddad 2016-04-28 13:45:26 PDT
*** Bug 157144 has been marked as a duplicate of this bug. ***
Comment 5 Alexey Proskuryakov 2016-04-28 19:53:21 PDT
Re-opening, because the test was only marked as flaky, not fixed.
Comment 6 Daniel Bates 2017-04-25 13:26:31 PDT
(In reply to youenn fablet from comment #0)
> imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on
> some bots

I am unclear how this test could have passed on any bot. At the time of writing, WebCore does not honor X-Content-Type-Options: nosniff in the HTTP response for a stylesheet. Once we add such support in bug #136452 then this test will pass on platforms that ENABLE(NOSNIFF) and whose networking stack supports nosniff.
Comment 7 Daniel Bates 2017-04-25 13:27:54 PDT
Fixed in <http://trac.webkit.org/changeset/215753> (bug #136452).
Comment 8 youenn fablet 2017-04-25 13:53:29 PDT
(In reply to Daniel Bates from comment #6)
> (In reply to youenn fablet from comment #0)
> > imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on
> > some bots
> 
> I am unclear how this test could have passed on any bot. At the time of
> writing, WebCore does not honor X-Content-Type-Options: nosniff in the HTTP
> response for a stylesheet. Once we add such support in bug #136452 then this
> test will pass on platforms that ENABLE(NOSNIFF) and whose networking stack
> supports nosniff.

Failing is meant in terms of -expected.txt equality, not in terms of all tests outputting PASS.