Bug 15714
Summary: | REGRESSION: insertion point disappears after deleting the last character in inline hole | ||
---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Major | CC: | darin, justin.garcia |
Priority: | P1 | Keywords: | InRadar, Regression |
Version: | 523.x (Safari 3) | ||
Hardware: | Mac | ||
OS: | OS X 10.4 |
Alexey Proskuryakov
Steps to reproduce:
1. Type any single character with Kotoeri.
2. Press backspace.
Results: insertion point disappears; further keypresses have no effect.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Actually, I'm seeing the insertion point disappear all the time when typing with RuSwitcher, even when not using Backspace. I'm not opening a new bug as I hope that the root cause is the same.
Makes typing really hard for me :(
Alexey Proskuryakov
This was apparently introduced in r27009 with a fix for rdar://problem/5544856 and (incidentally) bug 15702.
David Kilzer (:ddkilzer)
<rdar://problem/5576619>
Justin Garcia
Investigating...
Justin Garcia
I have a fix, TypingCommand::deleteSelection needs to call typingAddedToOpenCommand(), which will take the command's endingSelection and set it as selection. Working on a layout test.
Alexey Proskuryakov
Fixed in <http://trac.webkit.org/projects/webkit/changeset/27488>.