Bug 157103

Summary:

Improve caching of FontCascadeFonts

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
wip	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none

Antti Koivisto

Reported 2016-04-27 14:37:21 PDT

We should be able to keep them and the associated glyph and width caches over page loads.

Attachments
wip (43.11 KB, patch) 2016-04-27 14:37 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-yosemite (4.55 MB, application/zip) 2016-04-27 15:26 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (3.87 MB, application/zip) 2016-04-27 15:30 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (4.64 MB, application/zip) 2016-04-27 15:39 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.13 MB, application/zip) 2016-04-27 15:46 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2016-04-27 14:37:54 PDT

Created attachment 277535 [details] wip

WebKit Commit Bot

Comment 2 2016-04-27 14:39:38 PDT

Attachment 277535 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/FontCascadeFonts.h:66: The parameter name "fontSelector" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/graphics/FontCascadeFontsCache.cpp:55: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/FontCascadeFontsCache.h:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/FontCascadeFontsCache.h:68: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2016-04-27 15:26:35 PDT

Comment on attachment 277535 [details] wip Attachment 277535 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1230698 New failing tests: css3/font-feature-settings-font-face-rendering.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-001.html printing/page-break-widows.html svg/text/multichar-glyph.svg printing/page-break-orphans.html printing/page-rule-in-media-query.html printing/page-break-orphans-and-widows.html fast/regions/region-styling/region-style-image-background-color.html svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg printing/simple-lines-break.html printing/width-overflow.html printing/setPrinting.html printing/compositing-layer-printing.html css3/font-variant-font-face-all.html svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg

Build Bot

Comment 4 2016-04-27 15:26:39 PDT

Created attachment 277541 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-04-27 15:30:06 PDT

Comment on attachment 277535 [details] wip Attachment 277535 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1230705 New failing tests: css3/font-feature-settings-font-face-rendering.html css3/font-variant-font-face-all.html printing/page-break-widows.html svg/text/multichar-glyph.svg printing/page-break-orphans.html printing/page-rule-in-media-query.html printing/page-break-orphans-and-widows.html fast/regions/region-styling/region-style-image-background-color.html fast/css/scrollbar-dynamic-style-change.html svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg printing/simple-lines-break.html printing/width-overflow.html printing/setPrinting.html printing/compositing-layer-printing.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-001.html svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg

Build Bot

Comment 6 2016-04-27 15:30:10 PDT

Created attachment 277542 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-04-27 15:39:39 PDT

Comment on attachment 277535 [details] wip Attachment 277535 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1230708 New failing tests: css3/font-feature-settings-font-face-rendering.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-001.html printing/page-break-widows.html svg/text/multichar-glyph.svg printing/page-break-orphans.html printing/page-rule-in-media-query.html printing/page-break-orphans-and-widows.html fast/regions/region-styling/region-style-image-background-color.html svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg printing/simple-lines-break.html printing/width-overflow.html printing/setPrinting.html printing/compositing-layer-printing.html css3/font-variant-font-face-all.html svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg

Build Bot

Comment 8 2016-04-27 15:39:43 PDT

Created attachment 277543 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-04-27 15:46:29 PDT

Comment on attachment 277535 [details] wip Attachment 277535 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1230712 New failing tests: css3/font-feature-settings-font-face-rendering.html svg/custom/glyph-selection-non-bmp.svg css3/font-variant-font-face-all.html imported/blink/imported/csswg-test/css-writing-modes-3/bidi-embed-001.html fast/regions/region-styling/region-style-image-background-color.html

Build Bot

Comment 10 2016-04-27 15:46:32 PDT

Created attachment 277545 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4

Note You need to log in before you can comment on or make changes to this bug.