Bug 157077

Summary: Let the bindings generator use WTF::Optional for optional parameters using [Clamp]
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, rniwa, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-yosemite
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Archive of layout-test-results from ews114 for mac-yosemite
none
Patch
none
Patch none

Description Chris Dumez 2016-04-27 10:26:15 PDT
Let the bindings generator use WTF::Optional for optional parameters using [Clamp], if they do not have a default value.
Comment 1 Chris Dumez 2016-04-27 10:27:31 PDT
Created attachment 277487 [details]
Patch
Comment 2 Build Bot 2016-04-27 11:17:23 PDT
Comment on attachment 277487 [details]
Patch

Attachment 277487 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1229767

New failing tests:
http/tests/websocket/tests/hybi/client-close.html
Comment 3 Build Bot 2016-04-27 11:17:28 PDT
Created attachment 277495 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-04-27 11:20:24 PDT
Comment on attachment 277487 [details]
Patch

Attachment 277487 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1229766

New failing tests:
http/tests/websocket/tests/hybi/client-close.html
Comment 5 Build Bot 2016-04-27 11:20:28 PDT
Created attachment 277496 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-04-27 11:26:04 PDT
Comment on attachment 277487 [details]
Patch

Attachment 277487 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1229771

New failing tests:
http/tests/websocket/tests/hybi/client-close.html
Comment 7 Build Bot 2016-04-27 11:26:09 PDT
Created attachment 277497 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 8 Build Bot 2016-04-27 11:30:05 PDT
Comment on attachment 277487 [details]
Patch

Attachment 277487 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1229778

New failing tests:
http/tests/websocket/tests/hybi/client-close.html
Comment 9 Build Bot 2016-04-27 11:30:10 PDT
Created attachment 277498 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Chris Dumez 2016-04-27 12:21:11 PDT
Created attachment 277524 [details]
Patch
Comment 11 Chris Dumez 2016-04-27 12:45:54 PDT
Created attachment 277528 [details]
Patch
Comment 12 WebKit Commit Bot 2016-04-27 16:31:12 PDT
Comment on attachment 277528 [details]
Patch

Clearing flags on attachment: 277528

Committed r200158: <http://trac.webkit.org/changeset/200158>
Comment 13 WebKit Commit Bot 2016-04-27 16:31:18 PDT
All reviewed patches have been landed.  Closing bug.