Bug 157056

Summary: test harness tests complain about testRunner not being declared inside a browser
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Fixes the bug achristensen: review+

Ryosuke Niwa
Reported 2016-04-26 17:59:46 PDT
When you open a test written using testharness.js, it complains about testRunner not being defined in the line 44 of testharnessreport.js
Attachments
Fixes the bug (5.27 KB, patch)
2016-04-26 18:07 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixes the bug (5.29 KB, patch)
2016-04-26 18:09 PDT, Ryosuke Niwa 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-04-26 18:07:37 PDT
Created attachment 277429 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2016-04-26 18:09:28 PDT
Created attachment 277430 [details] Fixes the bug
Alex Christensen
Comment 3 2016-04-27 00:01:40 PDT
Comment on attachment 277430 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=277430&action=review > LayoutTests/resources/testharnessreport.js:-44 > -setup({"output": false, "explicit_timeout": !!testRunner}); A better fix would be to just replace !!testRunner with !!self.testRunner.
Ryosuke Niwa
Comment 4 2016-04-27 00:03:31 PDT
(In reply to comment #3) > Comment on attachment 277430 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277430&action=review > > > LayoutTests/resources/testharnessreport.js:-44 > > -setup({"output": false, "explicit_timeout": !!testRunner}); > > A better fix would be to just replace !!testRunner with !!self.testRunner. That would turn the entire page into a plain text without all the default UI. We currently have access to the default UI by the virtue of this line throwing and subsequent lines of the script not running inside a browser.
Alex Christensen
Comment 5 2016-04-27 22:29:25 PDT
Comment on attachment 277430 [details] Fixes the bug You're right. It does look nicer with your change instead of my more concise suggestion.
Ryosuke Niwa
Comment 6 2016-04-29 12:39:11 PDT
Committed r200255: <http://trac.webkit.org/changeset/200255>
Note You need to log in before you can comment on or make changes to this bug.