Bug 157055

Summary:

RTL native <select> buttons should have arrows on left

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mmaxfield: review+, buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews113 for mac-yosemite	none

Dean Jackson

Reported 2016-04-26 17:40:51 PDT

RTL native <select> buttons should have arrows on left

Attachments
Patch (81.20 KB, patch) 2016-04-26 17:56 PDT, Dean Jackson	mmaxfield: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.12 MB, application/zip) 2016-04-26 18:39 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1001.94 KB, application/zip) 2016-04-26 18:43 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (701.31 KB, application/zip) 2016-04-26 18:48 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-yosemite (1.05 MB, application/zip) 2016-04-26 18:52 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Dean Jackson

Comment 1 2016-04-26 17:56:18 PDT

Created attachment 277428 [details] Patch

Dean Jackson

Comment 2 2016-04-26 17:57:04 PDT

I changed a test so EWS will fail on most ports. I'll have to update the results.

Myles C. Maxfield

Comment 3 2016-04-26 18:04:35 PDT

Comment on attachment 277428 [details] Patch r=me assuming EWS is happy

Build Bot

Comment 4 2016-04-26 18:39:15 PDT

Comment on attachment 277428 [details] Patch Attachment 277428 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1226161 New failing tests: fast/text/international/pop-up-button-text-alignment-and-direction.html fast/text/international/bidi-menulist.html

Build Bot

Comment 5 2016-04-26 18:39:19 PDT

Created attachment 277433 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-04-26 18:43:43 PDT

Comment on attachment 277428 [details] Patch Attachment 277428 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1226174 New failing tests: fast/text/international/pop-up-button-text-alignment-and-direction.html fast/text/international/bidi-menulist.html

Build Bot

Comment 7 2016-04-26 18:43:48 PDT

Created attachment 277434 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-04-26 18:48:40 PDT

Comment on attachment 277428 [details] Patch Attachment 277428 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1226172 New failing tests: fast/forms/select-writing-direction-natural.html

Build Bot

Comment 9 2016-04-26 18:48:44 PDT

Created attachment 277435 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4

Build Bot

Comment 10 2016-04-26 18:52:51 PDT

Comment on attachment 277428 [details] Patch Attachment 277428 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1226182 New failing tests: fast/text/international/pop-up-button-text-alignment-and-direction.html fast/text/international/bidi-menulist.html

Build Bot

Comment 11 2016-04-26 18:52:55 PDT

Created attachment 277436 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Dean Jackson

Comment 12 2016-04-26 19:02:52 PDT

Committed r200118: <http://trac.webkit.org/changeset/200118>

Note You need to log in before you can comment on or make changes to this bug.