Summary: | Improve jsc --help and making sampling options | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | JavaScriptCore | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, keith_miller, mark.lam, msaboff, ossy, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-04-25 19:35:18 PDT
Created attachment 277311 [details]
[PATCH] Proposed Fix
Attachment 277311 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 277311 [details] [PATCH] Proposed Fix Clearing flags on attachment: 277311 Committed r200092: <http://trac.webkit.org/changeset/200092> All reviewed patches have been landed. Closing bug. (In reply to comment #0) > * SUMMARY > Improve jsc --help and making sampling options > > • --help doesn't mention --reportSamplingProfilerData > • --reportSamplingProfilerData is hard to remember, lets call it --sample > • --samplingProfilerTimingInterval is hard to remember, lets call it > --sampleInterval > • --options used to print out all options and exit, allowing you to > discover options, now it only prints overloaded options > • lets make --options output all options with help data > • lets keep --dumpOptions outputting just overridden options Thanks for getting back the old/new --options behaviour . :) |