Bug 156983

Summary: media/video-fullscreen-restriction-removed.html is flaky on Mac
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, Ms2ger
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Proposed patch. none

Description Ryan Haddad 2016-04-25 09:24:41 PDT
media/video-fullscreen-restriction-removed.html is flaky on Mac

Test seems to have been flaky since added with <http://trac.webkit.org/changeset/199667>

Most recent failure:

Flakiness dashboard:

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/video-fullscreen-restriction-removed-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/video-fullscreen-restriction-removed-actual.txt
@@ -1,6 +1,6 @@
 Test that "fullscreen requires user gesture restriction" is removed by a user gesture.
-Click me!
+  Click me!
 RUN(internals.setMediaElementRestrictions(video, "RequireUserGestureForFullscreen"))
 * set video.src
@@ -18,8 +18,6 @@
 EXPECTED (video.paused == 'true') OK
-EXPECTED (video.paused == 'false') OK
+FAIL: did not end fast enough
Comment 1 Ryan Haddad 2016-04-25 09:27:08 PDT
Marked test as flaky in <http://trac.webkit.org/projects/webkit/changeset/200029>
Comment 2 Eric Carlson 2016-04-26 10:50:20 PDT
Created attachment 277399 [details]
Proposed patch.
Comment 3 WebKit Commit Bot 2016-04-27 11:57:28 PDT
Comment on attachment 277399 [details]
Proposed patch.

Clearing flags on attachment: 277399

Committed r200137: <http://trac.webkit.org/changeset/200137>
Comment 4 WebKit Commit Bot 2016-04-27 11:57:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-08-14 02:07:52 PDT
The expectation removed in r200137 is not the one added in r200029; the latter is still present.