Bug 156949 – [Win] Zoom page when Ctrl +/- is pressed.

• Component: WebKit Misc.
• Status: NEW

On Windows, the page is not zoomed if the WebView window has focus, and Ctrl +/- is pressed.

Created attachment 277142 [details]
Patch

[Daniel Bates]

Comment on attachment 277142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277142&action=review

> Source/WebKit/win/ChangeLog:8
> +        On Windows, the page is not zoomed if the WebView window has focus, and Ctrl +/- is pressed.

Shouldn't the embedding client control zooming? I mean, a non-browser app may embed a WebView and not want to allow zooming of its content.

> Source/WebKit/win/WebView.cpp:2232
> +        return SUCCEEDED(zoomIn(false));

Shouldn't we be passing m_zoomsTextOnly instead of false here to account for whether text-only zooming is enabled?

> Source/WebKit/win/WebView.cpp:2235
> +        return SUCCEEDED(zoomOut(false));

Ditto.

(In reply to comment #2)
> Comment on attachment 277142 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277142&action=review
>

Thanks for reviewing!
 
> > Source/WebKit/win/ChangeLog:8
> > +        On Windows, the page is not zoomed if the WebView window has focus, and Ctrl +/- is pressed.
> 
> Shouldn't the embedding client control zooming? I mean, a non-browser app
> may embed a WebView and not want to allow zooming of its content.
> 

Yes, this is a good point. Clients can for example do this by subclassing the WebView window procedure, if we don't implement some other way of notifying the client.

[Daniel Bates]

Comment on attachment 277142 [details]
Patch

I'm r-'ing this patch because the embedding client should control zooming, including taking responsibility to expose such zoom functionality to the user. The embedding client should direct WebKit when the content should be zoomed in or out as well as whether such zooming should be text-only.