| Summary: | Renaming SpecInt32, SpecInt52, MachineInt to SpecInt32Only, SpecInt52Only, AnyInt. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, keith_miller, msaboff, saam, ysuzuki | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mark Lam
2016-04-22 17:28:49 PDT
Created attachment 277120 [details]
proposed patch.
Attachment 277120 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/SpeculatedType.cpp:185: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 37 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 277120 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=277120&action=review > Source/JavaScriptCore/bytecode/SpeculatedType.h:71 > +static const SpeculatedType SpecAnyInt = SpecInt32Only | SpecInt52Only; // It's something that we can do machine int arithmetic on. It's a shame that this is called AnyInt while we have: > Source/JavaScriptCore/bytecode/SpeculatedType.h:72 > static const SpeculatedType SpecInt52AsDouble = 1u << 24; // It's definitely an Int52 and it's inside a double. Under the new nomenclature, this should be called SpecAnyIntAsDouble. > Source/JavaScriptCore/bytecode/SpeculatedType.h:73 > +static const SpeculatedType SpecInteger = SpecAnyInt | SpecInt52AsDouble; // It's definitely some kind of integer. And this. I think this is why the other one was called MachineInt. Looking at the code, it seems that SpecInteger is used only in one place. We could just remove SpecInteger and replace its one use with "SpecAnyInt | SpecAnyIntAsDouble" Created attachment 277258 [details]
proposed patch w/ Fil's feedback applied.
Created attachment 277259 [details]
Diff of patches (last vs current) for your convenience.
Attachment 277258 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/SpeculatedType.cpp:185: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 1 in 37 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thanks for the review. Landed in r200034: <http://trac.webkit.org/r200034>. |