Summary: | [Fetch API] FetchResponse should return a ReadableStream even if disturbed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, commit-queue, darin | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 151937 | ||||||||
Attachments: |
|
Description
youenn fablet
2016-04-22 07:33:19 PDT
Created attachment 277060 [details]
Patch
Comment on attachment 277060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277060&action=review > Source/WebCore/Modules/fetch/FetchResponse.cpp:296 > + ASSERT(!FetchBodyOwner::isDisturbed()); Why not just ASSERT(!isDisturbed())? Thanks for the review. (In reply to comment #2) > Comment on attachment 277060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277060&action=review > > > Source/WebCore/Modules/fetch/FetchResponse.cpp:296 > > + ASSERT(!FetchBodyOwner::isDisturbed()); > > Why not just ASSERT(!isDisturbed())? Right, this is only an ASSERT. I'll update the patch accordingly. Created attachment 277677 [details]
Patch for landing
Comment on attachment 277677 [details] Patch for landing Clearing flags on attachment: 277677 Committed r200235: <http://trac.webkit.org/changeset/200235> All reviewed patches have been landed. Closing bug. |