Bug 156871

Summary: [JSC] Commute FDiv-by-constant into FMul-by-reciprocal when it is safe
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, ossy, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 156892    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Benjamin Poulain
Reported 2016-04-21 14:34:28 PDT
[JSC] Commute FDiv-by-constant into FMul-by-reciprocal when it is safe
Attachments
Patch (17.42 KB, patch)
2016-04-21 14:47 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.42 KB, patch)
2016-04-21 20:43 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-04-21 14:47:50 PDT
Created attachment 276964 [details] Patch
Filip Pizlo
Comment 2 2016-04-21 15:02:07 PDT
Comment on attachment 276964 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276964&action=review > Source/JavaScriptCore/ChangeLog:16 > + LLVM does something similar in InstCombine. Is this bit-equivalent for sure? LLVM doesn't have to obey IEEE as well as we do.
Benjamin Poulain
Comment 3 2016-04-21 20:43:54 PDT
Created attachment 277002 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-04-21 21:46:34 PDT
Comment on attachment 277002 [details] Patch for landing Clearing flags on attachment: 277002 Committed r199866: <http://trac.webkit.org/changeset/199866>
WebKit Commit Bot
Comment 5 2016-04-21 21:46:37 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2016-04-22 01:56:59 PDT
(In reply to comment #4) > Comment on attachment 277002 [details] > Patch for landing > > Clearing flags on attachment: 277002 > > Committed r199866: <http://trac.webkit.org/changeset/199866> and the buildfix landed in https://trac.webkit.org/changeset/199868 Please don't ignore red EWS bubbles, it's not WebKit2.
Note You need to log in before you can comment on or make changes to this bug.