Bug 156870

Summary: [css-grid] Fix bug with positioned items in vertical writing mode
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, simon.fraser, svillar
Priority: P2 Keywords: BlinkMergeCandidate
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2016-04-21 14:17:29 PDT
If we use border in the grid container and positioned items in vertical writing mode, the items are not placed in the right position. The issue is that in RenderGrid::offsetAndBreadthForPositionedChild() we are using borderLeft(). This is a port of: https://codereview.chromium.org/1909153002/
Attachments
Patch (8.25 KB, patch)
2016-04-21 14:20 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-04-21 14:20:43 PDT
Created attachment 276959 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-22 00:54:02 PDT
Comment on attachment 276959 [details] Patch Clearing flags on attachment: 276959 Committed r199874: <http://trac.webkit.org/changeset/199874>
WebKit Commit Bot
Comment 3 2016-04-22 00:54:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.