Bug 156869

Summary: Intrinsic content height computation should ignore box-sizing value
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, ryanhaddad, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=156917
Bug Depends on: 156918    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
zalan: review+
Patch zalan: review+

Description Dave Hyatt 2016-04-21 14:15:21 PDT 
We already get passed in the content height, so subtracting out borders/padding from that value because of box-sizing results in an incorrect value.
Comment 1 Dave Hyatt 2016-04-21 14:15:38 PDT 
This breaks messenger.com on Facebook.
Comment 2 Dave Hyatt 2016-04-21 14:16:08 PDT 
Created attachment 276958 [details]
Patch
Comment 3 Dave Hyatt 2016-04-22 08:47:51 PDT 
This is the cause of:

<rdar://problem/23204668> REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken in some window sizes
Comment 4 Dave Hyatt 2016-04-22 08:50:38 PDT 
Created attachment 277063 [details]
Patch
Comment 5 Dave Hyatt 2016-04-22 08:57:56 PDT 
Fixed in r199877.
Comment 6 WebKit Commit Bot 2016-04-22 10:51:27 PDT 
Re-opened since this is blocked by bug 156918
Comment 7 Ryan Haddad 2016-04-22 11:24:35 PDT 
*** Bug 156917 has been marked as a duplicate of this bug. ***
Comment 8 Dave Hyatt 2016-04-22 11:42:54 PDT 
Created attachment 277081 [details]
Patch

I uploaded the wrong patch. The real fix was more low-level in order to apply everywhere.
Comment 9 Dave Hyatt 2016-04-22 12:42:12 PDT 
Landed in r199895.