Summary: | More improvements and explanations regarding resetting CSS properties on the <math> element | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alex, darin | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 133603 | ||||||||
Bug Blocks: | 156837, 156839 | ||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2016-04-21 02:22:20 PDT
Created attachment 276907 [details]
WIP Patch (for EWS testing)
Created attachment 276910 [details]
Patch
Comment on attachment 276910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276910&action=review Seems OK. It seems really peculiar to list fonts that are almost all available together. Given the discussion here there is clearly a call, longer term, for some clever system to choose which font to use based on which non-math font is being used in the surrounding content. > Source/WebCore/css/mathml.css:73 > + We put Cambria Math first since it is pre-installed on Windows 7 and higher. Not sure I understand the logic here. No reason I can think of to put more-often-installed fonts first. (In reply to comment #3) > It seems really peculiar to list fonts that are almost all available > together. Given the discussion here there is clearly a call, longer term, > for some clever system to choose which font to use based on which non-math > font is being used in the surrounding content. Definitely. For now, the idea is to not miss any math font that can be installed on the system. > > Source/WebCore/css/mathml.css:73 > > + We put Cambria Math first since it is pre-installed on Windows 7 and higher. > > Not sure I understand the logic here. No reason I can think of to put > more-often-installed fonts first. As I said on bug 133603, this is a bit arbitrary... Maybe a better reason is because Cambria Math is pre-installed it has been more tested than the two others. Committed r199869: <http://trac.webkit.org/changeset/199869> (In reply to comment #3) > It seems really peculiar to list fonts that are almost all available > together. Given the discussion here there is clearly a call, longer term, > for some clever system to choose which font to use based on which non-math > font is being used in the surrounding content. For the record and future discussions, I've opened an issue in the MathML in HTML5 implementation note: https://github.com/MathML/MathMLinHTML5/issues/26 Ideally, I'd like CSS properties/keywords that could just be used in the default user agent stylesheet to tell the web engine to perform such clever trick. That way users won't be surprised by a non-CSS compatible behavior or can at least override that behavior if they don't like it. |