| Summary: | MathOperator: Add fallback mechanisms for stretching and mirroring radical symbols | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||||||||||||||||||||
| Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | alex, bfulgham, cfleizach, commit-queue, darin, dbarton, esprehn+autocc, glenn, jfernandez, kondapallykalyan, mrobinson, rego, svillar | ||||||||||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||||||||||||||||
| OS: | All | ||||||||||||||||||||||||||||||||||
| Bug Depends on: | 152244 | ||||||||||||||||||||||||||||||||||
| Bug Blocks: | 153987, 157519 | ||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||
Created attachment 276913 [details]
testcase
Created attachment 276917 [details]
WIP Patch
Created attachment 276918 [details]
Patch for EWS testing
Comment on attachment 276918 [details] Patch for EWS testing Attachment 276918 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1196372 New failing tests: mathml/radical-fallback.html Created attachment 276923 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 276918 [details] Patch for EWS testing Attachment 276918 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1196432 New failing tests: mathml/presentation/inferred-mrow-stretchy.html mathml/radical-fallback.html mathml/presentation/tokenElements-dynamic.html mathml/presentation/direction-overall.html mathml/presentation/inferred-mrow-baseline.html mathml/presentation/phantom.html mathml/presentation/stretchy-depth-height.html mathml/presentation/radical-bar-visibility.html mathml/wbr-in-mroot-crash.html mathml/presentation/menclose-notation-radical.html Created attachment 276926 [details]
Archive of layout-test-results from ews115 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 276927 [details]
Patch for EWS testing
Created attachment 276930 [details]
Patch
Created attachment 276931 [details]
Patch for EWS testing
Created attachment 277374 [details]
Patch
Created attachment 278394 [details] Patch Updating after https://trac.webkit.org/changeset/200569 Comment on attachment 278394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278394&action=review > Source/WebCore/rendering/mathml/RenderMathMLRadicalOperator.h:39 > + extra whitespace here Created attachment 278608 [details]
Patch for EWS testing
Comment on attachment 278608 [details] Patch for EWS testing Attachment 278608 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1302950 New failing tests: mathml/radical-fallback.html mathml/presentation/roots.xhtml Created attachment 278612 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Created attachment 278613 [details]
Patch for EWS testing
Created attachment 278614 [details]
Patch
Created attachment 281530 [details]
Patch
Comment on attachment 281530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281530&action=review > Source/WebCore/ChangeLog:7 > + We need a description of the whole patch here _and_ a rationale for the change. > Source/WebCore/rendering/mathml/MathOperator.cpp:359 > + m_radicalVerticalScale = static_cast<float>(targetSize) / height; targetSize.toFloat() Committed r202161: <http://trac.webkit.org/changeset/202161> |
This bug will cover: - Drawing of stretched radical using strokePath (as currently done in RenderMathMLRadicalOperator::paint) as a fallback for fonts without a MATH table. - Mirroring of radical symbol in RTL mode (as done by the MathOperator.cpp changes from attachment 276632 [details]) because for now it seems hard to support glyph-level mirroring via the rtlm feature.