Bug 156806

Summary:

Crash under needsAppleMailPaginationQuirk()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Layout and Rendering

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, darin, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=156852

Attachments:

Description	Flags
Patch	none
Patch	none

Chris Dumez

Reported 2016-04-20 12:57:20 PDT

Stop repeatedly atomizing string in needsAppleMailPaginationQuirk() and instead leverage the operator==(const AtomicString&, const char*).

Attachments
Patch (1.62 KB, patch) 2016-04-20 13:04 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (1.83 KB, patch) 2016-04-20 13:13 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-04-20 13:04:15 PDT

Created attachment 276846 [details] Patch

Chris Dumez

Comment 2 2016-04-20 13:08:24 PDT

rdar://problem/23323479

Chris Dumez

Comment 3 2016-04-20 13:08:37 PDT

[ 0] 0x00007fff96352582 WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) [inlined] WTF::String::impl() const at WTFString.h:153 [ 0] 0x00007fff96352582 WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) [inlined] WTF::AtomicString::impl() const at AtomicString.h:94 [ 0] 0x00007fff96352582 WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) [inlined] WTF::operator==(WTF::AtomicString const&, WTF::AtomicString const&) at AtomicString.h:194 [ 0] 0x00007fff96352582 WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) [inlined] WebCore::needsAppleMailPaginationQuirk(WebCore::RootInlineBox&) + 101 at RenderBlockFlow.cpp:1623 [ 0] 0x00007fff9635251d WebCore`WebCore::RenderBlockFlow::adjustLinePositionForPagination(WebCore::RootInlineBox*, WebCore::LayoutUnit&, bool&, WebCore::RenderFlowThread*) + 2141 at RenderBlockFlow.cpp:1711 [ 1] 0x00007fff9635de9c WebCore`WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&, WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::InlineIterator const&, WebCore::BidiStatus const&, unsigned int) + 4748 at RenderBlockLineLayout.cpp:1306:21 [ 2] 0x00007fff9635b6af WebCore`WebCore::RenderBlockFlow::layoutRunsAndFloats(WebCore::LineLayoutState&, bool) + 1167 at RenderBlockLineLayout.cpp:1202:5 [ 3] 0x00007fff9635fa9b WebCore`WebCore::RenderBlockFlow::layoutLineBoxes(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&) + 2219 at RenderBlockLineLayout.cpp:1612:9 [ 4] 0x00007fff9634bb7d WebCore`WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) + 941 at RenderBlockFlow.cpp:483:9

Chris Dumez

Comment 4 2016-04-20 13:13:30 PDT

Created attachment 276847 [details] Patch

WebKit Commit Bot

Comment 5 2016-04-20 14:06:44 PDT

Comment on attachment 276847 [details] Patch Clearing flags on attachment: 276847 Committed r199784: <http://trac.webkit.org/changeset/199784>

WebKit Commit Bot

Comment 6 2016-04-20 14:06:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.