Bug 156763

Summary: Web Inspector: Hide ["PrivateSymbol.concatSlowPath"] and other PrivateSymbols from memory edges
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot
none
Patch
joepeck: review+
Patch none

Timothy Hatcher
Reported 2016-04-19 15:32:11 PDT
These should be considered internal / private.
Attachments
Screenshot (82.34 KB, image/png)
2016-04-19 15:32 PDT, Timothy Hatcher 		no flags
Details
Patch (2.75 KB, patch)
2016-09-10 15:00 PDT, Devin Rousso 		joepeck: review+
DetailsFormatted DiffDiff
Patch (2.64 KB, patch)
2016-09-12 14:18 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2016-04-19 15:32:24 PDT
Created attachment 276763 [details] Screenshot
Alexey Proskuryakov
Comment 2 2016-09-08 13:59:51 PDT
<rdar://problem/28213642>
Devin Rousso
Comment 3 2016-09-10 15:00:00 PDT
Created attachment 288502 [details] Patch
Joseph Pecoraro
Comment 4 2016-09-12 13:18:47 PDT
Comment on attachment 288502 [details] Patch I've always hesitated doing this quick fix because what if someone has a string property that actually starts with the string "PrivateSymbol". That said, I think this handles the 99% case. We should have a FIXME or file a follow-up to at some point actually distinguish between a private symbol property (an internal implementation detail of JavaScriptCore) and a regular Symbol property.
Devin Rousso
Comment 5 2016-09-12 13:40:20 PDT
(In reply to comment #4) > I've always hesitated doing this quick fix because what if someone has a > string property that actually starts with the string "PrivateSymbol". That > said, I think this handles the 99% case. We should have a FIXME or file a > follow-up to at some point actually distinguish between a private symbol > property (an internal implementation detail of JavaScriptCore) and a regular > Symbol property. Just so I understand correctly, where does the "PrivateSymbol" actually originate from? Does it just represent a Symbol(), or is it something different?
Devin Rousso
Comment 6 2016-09-12 14:18:49 PDT
Created attachment 288609 [details] Patch
WebKit Commit Bot
Comment 7 2016-09-12 14:48:54 PDT
Comment on attachment 288609 [details] Patch Clearing flags on attachment: 288609 Committed r205827: <http://trac.webkit.org/changeset/205827>
WebKit Commit Bot
Comment 8 2016-09-12 14:48:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.