Bug 156753

Summary:

[Fetch API] Add support for fetch mode, in particular cors

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa, tri

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

157837

Bug Blocks:

151937

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Adding WK2 specific baselines for https tests	none
Adding WK2 specific baselines for https tests	none
Patch for landing	none

youenn fablet

Reported 2016-04-19 11:51:53 PDT

fetch API should support mode option, in particular to handle cors.

Attachments
Patch (119.15 KB, patch) 2016-04-19 11:56 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (741.45 KB, application/zip) 2016-04-19 12:45 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (1.63 MB, application/zip) 2016-04-19 13:28 PDT, Build Bot	no flags	Details
Patch (91.19 KB, patch) 2016-07-25 09:14 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (832.91 KB, application/zip) 2016-07-25 10:00 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (1.37 MB, application/zip) 2016-07-25 10:14 PDT, Build Bot	no flags	Details
Adding WK2 specific baselines for https tests (98.74 KB, patch) 2016-07-26 11:13 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Adding WK2 specific baselines for https tests (105.08 KB, patch) 2016-07-26 11:56 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (105.08 KB, patch) 2016-07-26 12:48 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2016-04-19 11:56:34 PDT

Created attachment 276738 [details] Patch

Build Bot

Comment 2 2016-04-19 12:45:44 PDT

Comment on attachment 276738 [details] Patch Attachment 276738 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1187157 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies.html imported/w3c/web-platform-tests/fetch/api/cors/cors-filtering-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-filtering.html imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html

Build Bot

Comment 3 2016-04-19 12:45:46 PDT

Created attachment 276746 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-04-19 13:28:12 PDT

Comment on attachment 276738 [details] Patch Attachment 276738 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1187227 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-filtering-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight.html imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect.html imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.html imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-credentials.html imported/w3c/web-platform-tests/fetch/api/basic/integrity-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-multiple-origins-worker.html imported/w3c/web-platform-tests/fetch/api/basic/integrity.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/cors/cors-filtering.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.html imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-multiple-origins.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.html

Build Bot

Comment 5 2016-04-19 13:28:14 PDT

Created attachment 276751 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

youenn fablet

Comment 6 2016-07-25 09:14:32 PDT

Created attachment 284491 [details] Patch

Build Bot

Comment 7 2016-07-25 10:00:24 PDT

Comment on attachment 284491 [details] Patch Attachment 284491 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1751812 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html

Build Bot

Comment 8 2016-07-25 10:00:26 PDT

Created attachment 284494 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-07-25 10:13:57 PDT

Comment on attachment 284491 [details] Patch Attachment 284491 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1751830 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html

Build Bot

Comment 10 2016-07-25 10:14:01 PDT

Created attachment 284496 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

youenn fablet

Comment 11 2016-07-26 11:13:50 PDT

Created attachment 284605 [details] Adding WK2 specific baselines for https tests

youenn fablet

Comment 12 2016-07-26 11:18:01 PDT

(In reply to comment #9) > Comment on attachment 284491 [details] > Patch > > Attachment 284491 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/1751830 > > New failing tests: > imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.html > imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html > imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html In WK1, fetch with HTTPS urls on WPT server is going fine. In Mac WK2, fetch with HTTPS urls on WPT server is stopped as the certificate is not valid. This may be related to bug 155132. I plan to land this patch with these specific baselines are added for Wk2.

youenn fablet

Comment 13 2016-07-26 11:56:53 PDT

Created attachment 284613 [details] Adding WK2 specific baselines for https tests

youenn fablet

Comment 14 2016-07-26 12:48:57 PDT

Created attachment 284620 [details] Patch for landing

WebKit Commit Bot

Comment 15 2016-07-26 13:19:15 PDT

Comment on attachment 284620 [details] Patch for landing Clearing flags on attachment: 284620 Committed r203732: <http://trac.webkit.org/changeset/203732>

WebKit Commit Bot

Comment 16 2016-07-26 13:19:19 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.