Bug 156746

Summary:

Clean up the ParkingLot uparking API a bit

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Web Template Framework

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	ggaren: review+
the patch	saam: review+
patch for landing	none

Filip Pizlo

Reported 2016-04-19 08:56:18 PDT

Patch forthcoming.

Attachments
the patch (15.10 KB, patch) 2016-04-19 08:59 PDT, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
the patch (30.73 KB, patch) 2016-04-19 17:40 PDT, Filip Pizlo	saam: review+	Details Formatted Diff Diff
patch for landing (11.99 KB, patch) 2016-04-19 19:05 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-04-19 08:59:27 PDT

Created attachment 276726 [details] the patch

WebKit Commit Bot

Comment 2 2016-04-19 09:01:27 PDT

Attachment 276726 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Condition.h:183: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Lock.cpp:97: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/benchmarks/LockSpeedTest.cpp:82: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 3 2016-04-19 11:13:17 PDT

Comment on attachment 276726 [details] the patch r=me

Filip Pizlo

Comment 4 2016-04-19 17:40:02 PDT

Created attachment 276784 [details] the patch

Filip Pizlo

Comment 5 2016-04-19 17:40:21 PDT

I put this up for re-review because I added a lot of stuff.

WebKit Commit Bot

Comment 6 2016-04-19 17:41:03 PDT

Attachment 276784 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Condition.h:183: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Lock.cpp:97: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/benchmarks/LockSpeedTest.cpp:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/benchmarks/LockSpeedTest.cpp:172: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/benchmarks/LockSpeedTest.cpp:445: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 5 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Saam Barati

Comment 7 2016-04-19 19:03:03 PDT

Comment on attachment 276784 [details] the patch r=me for the API change. I think that the LockSpeedTest changes should go in a separate patch.

Filip Pizlo

Comment 8 2016-04-19 19:05:55 PDT

Created attachment 276789 [details] patch for landing

WebKit Commit Bot

Comment 9 2016-04-19 19:08:32 PDT

Attachment 276789 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Condition.h:183: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Lock.cpp:97: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 10 2016-04-19 21:25:33 PDT

Landed in http://trac.webkit.org/changeset/199760

Note You need to log in before you can comment on or make changes to this bug.