Bug 156731

Summary: Toggling animation-play-state can re-start a finished animation
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: AnimationsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, dstockwell, ryanhaddad, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Testcase
none
Patch
none
Patch dino: review+

Simon Fraser (smfr)
Reported 2016-04-18 22:22:50 PDT
Created attachment 276694 [details] Testcase In the attached test case, hover the box and wait for the animation to finish. Then un-hover and re-hover. Note how the animation restarts. In other browsers, the animation does not restart, which is correct because the animation-name property still applies to the element. Our mistake is to completely remove finished animations in CompositeAnimation::updateKeyframeAnimations(). We need to keep some state around to know that we shouldn't re-run this animation when play-state changes.
Attachments
Testcase (769 bytes, text/html)
2016-04-18 22:22 PDT, Simon Fraser (smfr) 		no flags
Details
Patch (24.08 KB, patch)
2016-04-24 23:01 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (24.14 KB, patch)
2016-04-25 13:36 PDT, Simon Fraser (smfr) 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-04-24 23:01:55 PDT
Created attachment 277219 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-04-25 13:36:31 PDT
Created attachment 277273 [details] Patch
Dean Jackson
Comment 3 2016-04-25 13:47:14 PDT
Comment on attachment 277273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277273&action=review > Source/WebCore/ChangeLog:14 > + Fix by keeping state for keyframe animations in the Done state in the m_keyframeAnimations > + map. This allows for the removal of the You forgot to end this sentence
Simon Fraser (smfr)
Comment 4 2016-04-25 13:56:59 PDT
https://trac.webkit.org/r200047
Ryan Haddad
Comment 5 2016-04-25 16:59:46 PDT
This change appears to have caused fast/layers/no-clipping-overflow-hidden-added-after-transform.html to fail on mac-wk1 debug https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20%28Tests%29/r200051%20%284689%29/results.html
Note You need to log in before you can comment on or make changes to this bug.