| Summary: | allow jsc shell to dump sampling profiler data | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, ossy, sukolsak, ysuzuki | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Saam Barati
2016-04-18 19:53:37 PDT
Created attachment 276685 [details]
WIP
Created attachment 276737 [details]
patch
Attachment 276737 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/SamplingProfiler.h:31: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/JavaScriptCore/runtime/SamplingProfiler.cpp:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 276739 [details]
patch
Fix style
Comment on attachment 276739 [details] patch Clearing flags on attachment: 276739 Committed r199754: <http://trac.webkit.org/changeset/199754> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > Comment on attachment 276739 [details] > patch > > Clearing flags on attachment: 276739 > > Committed r199754: <http://trac.webkit.org/changeset/199754> It broke the cloop build. (In reply to comment #7) > (In reply to comment #5) > > Comment on attachment 276739 [details] > > patch > > > > Clearing flags on attachment: 276739 > > > > Committed r199754: <http://trac.webkit.org/changeset/199754> > > It broke the cloop build. Thanks. Will fix build fix in: http://trac.webkit.org/changeset/199763 |