Bug 156725

Summary: allow jsc shell to dump sampling profiler data
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, ossy, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
none
patch none

Saam Barati
Reported 2016-04-18 19:53:37 PDT
...
Attachments
WIP (6.95 KB, patch)
2016-04-18 19:53 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (9.61 KB, patch)
2016-04-19 11:47 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (9.62 KB, patch)
2016-04-19 12:00 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-04-18 19:53:53 PDT
Created attachment 276685 [details] WIP
Saam Barati
Comment 2 2016-04-19 11:47:48 PDT
Created attachment 276737 [details] patch
WebKit Commit Bot
Comment 3 2016-04-19 11:49:15 PDT
Attachment 276737 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/SamplingProfiler.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/runtime/SamplingProfiler.cpp:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 4 2016-04-19 12:00:29 PDT
Created attachment 276739 [details] patch Fix style
WebKit Commit Bot
Comment 5 2016-04-19 19:24:36 PDT
Comment on attachment 276739 [details] patch Clearing flags on attachment: 276739 Committed r199754: <http://trac.webkit.org/changeset/199754>
WebKit Commit Bot
Comment 6 2016-04-19 19:24:41 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2016-04-19 22:28:06 PDT
(In reply to comment #5) > Comment on attachment 276739 [details] > patch > > Clearing flags on attachment: 276739 > > Committed r199754: <http://trac.webkit.org/changeset/199754> It broke the cloop build.
Saam Barati
Comment 8 2016-04-19 22:39:38 PDT
(In reply to comment #7) > (In reply to comment #5) > > Comment on attachment 276739 [details] > > patch > > > > Clearing flags on attachment: 276739 > > > > Committed r199754: <http://trac.webkit.org/changeset/199754> > > It broke the cloop build. Thanks. Will fix
Saam Barati
Comment 9 2016-04-19 22:49:57 PDT
build fix in: http://trac.webkit.org/changeset/199763
Note You need to log in before you can comment on or make changes to this bug.