Bug 156710

Summary: fix CMake Xcode build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: NEW    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review+, commit-queue: commit-queue-

Alex Christensen
Reported 2016-04-18 11:40:59 PDT
fix CMake Xcode build
Attachments
Patch (62.18 KB, patch)
2016-04-18 11:53 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (60.62 KB, patch)
2016-04-18 21:37 PDT, Alex Christensen 		mcatanzaro: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-04-18 11:53:10 PDT
Created attachment 276649 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-18 11:54:42 PDT
Attachment 276649 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/cf/ArgumentCodersCF.mm:81: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit2/Shared/API/Cocoa/WebKit.mm:31: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2016-04-18 21:37:46 PDT
Created attachment 276689 [details] Patch
WebKit Commit Bot
Comment 4 2016-04-18 21:40:30 PDT
Attachment 276689 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/cf/ArgumentCodersCF.mm:81: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit2/Shared/API/Cocoa/WebKit.mm:31: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5 2016-04-25 11:42:00 PDT
Comment on attachment 276689 [details] Patch Rejecting attachment 276689 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 276689, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Kit2/Shared/cf/ArgumentCodersCF.cpp' patching file Source/WebKit2/WebKit2.xcodeproj/project.pbxproj patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/PlatformMac.cmake patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/PlatformMac.cmake Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Michael Catanzaro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1219041
Note You need to log in before you can comment on or make changes to this bug.