Summary: | build-webkit (and other build scripts) should hide setenv commands by default | ||
---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | ahmad.saleem792, ap, ddkilzer, emw, mjs, mrowe, sam |
Priority: | P2 | ||
Version: | 523.x (Safari 3) | ||
Hardware: | Mac | ||
OS: | OS X 10.4 |
Description
Eric Seidel (no email)
2007-10-24 12:18:13 PDT
The setenv commands are not duplicated for each call to gcc as you claim. I believe they're printed once for each non-compile phase, or something to that effect. If you implement this, please make it easy to disable this filtering as I often use build-webkit to check the values of the Xcode configuration variables, rather than make which always filters them out and is not easily configurable like build-webkit. What's wrong with doing this? build-webkit | grep -v setenv @ap - This enhancement is still applicable or we can close this? Thanks! People who want this behavior typically pipe through filter-build-webkit. And yes, as Mark pointed out, these are not duplicated, and are in fact often useful. It's the typical "make it quiet except when I actually want to see everything" problem, and I think that the best way to resolve this is by sticking to what Xcode does by default, and letting people use filter-build-webkit when desired. |