Bug 15668
| Summary: | build-webkit (and other build scripts) should hide setenv commands by default | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, ddkilzer, emw, mjs, mrowe, sam |
| Priority: | P2 | ||
| Version: | 523.x (Safari 3) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
Eric Seidel (no email)
build-webkit (and other build scripts) should hit setenv commands by default
*most* of the XCode build output is useless setenv commands (duplicated for each call to gcc). build-webkit should grep out this setenv output in a default "not quite so loud" mode. :)
I would do it, but I don't see a slick way of calling system and piping the output through grep. I think the way we'll have to do it is two open2() calls which pipe the output of xcodebuild to grep and the on to STDERR/STDOUT.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Rowe (bdash)
The setenv commands are not duplicated for each call to gcc as you claim. I believe they're printed once for each non-compile phase, or something to that effect. If you implement this, please make it easy to disable this filtering as I often use build-webkit to check the values of the Xcode configuration variables, rather than make which always filters them out and is not easily configurable like build-webkit.
David Kilzer (:ddkilzer)
What's wrong with doing this?
build-webkit | grep -v setenv
Ahmad Saleem
@ap - This enhancement is still applicable or we can close this? Thanks!
Alexey Proskuryakov
People who want this behavior typically pipe through filter-build-webkit.
And yes, as Mark pointed out, these are not duplicated, and are in fact often useful.
It's the typical "make it quiet except when I actually want to see everything" problem, and I think that the best way to resolve this is by sticking to what Xcode does by default, and letting people use filter-build-webkit when desired.