Bug 156546

Summary: [iOS] remote command should be considered user events
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Updated patch none

Eric Carlson
Reported 2016-04-13 10:39:36 PDT
Remote control commands are always triggered by a user gesture.
Attachments
Proposed patch. (9.62 KB, patch)
2016-04-13 11:03 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Updated patch (4.95 KB, patch)
2016-04-13 14:00 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2016-04-13 10:40:35 PDT
<rdar://problem/25560877>
Eric Carlson
Comment 2 2016-04-13 11:03:33 PDT
Created attachment 276335 [details] Proposed patch.
Jer Noble
Comment 3 2016-04-13 12:08:38 PDT
Comment on attachment 276335 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=276335&action=review > Source/WebCore/html/HTMLMediaElement.cpp:6649 > LOG(Media, "HTMLMediaElement::didReceiveRemoteControlCommand(%p) - %i", this, static_cast<int>(command)); > > + ++m_processingRemoteControlCommand; > + It seems much simpler to add the following here instead: UserGestureIndicator remoteControlUserGesture(DefinitelyProcessingUserGesture); This will tell the ScriptController that a user gesture is present, so all of the below should be unnecessary.
Eric Carlson
Comment 4 2016-04-13 14:00:11 PDT
Created attachment 276349 [details] Updated patch
WebKit Commit Bot
Comment 5 2016-04-13 15:09:35 PDT
Comment on attachment 276349 [details] Updated patch Clearing flags on attachment: 276349 Committed r199515: <http://trac.webkit.org/changeset/199515>
WebKit Commit Bot
Comment 6 2016-04-13 15:09:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.