Summary: | [iOS] do not exit AirPlay when the screen locks | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Eric Carlson
2016-04-12 07:50:02 PDT
Created attachment 276235 [details]
Proposed patch
Comment on attachment 276235 [details] Proposed patch Attachment 276235 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1142388 New failing tests: animations/trigger-container-scroll-empty.html Created attachment 276238 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 276256 [details]
Updated Patch.
Created attachment 276263 [details]
Updated Patch.
Comment on attachment 276263 [details] Updated Patch. Clearing flags on attachment: 276263 Committed r199383: <http://trac.webkit.org/changeset/199383> All reviewed patches have been landed. Closing bug. Reverted r199383 for reason: Seems to have caused a 0.5% PLT regression on iOS Committed r200141: <http://trac.webkit.org/changeset/200141> Created attachment 277763 [details]
Revised patch.
Comment on attachment 277763 [details] Revised patch. View in context: https://bugs.webkit.org/attachment.cgi?id=277763&action=review > Source/WebCore/html/MediaElementSession.cpp:364 > +#if !PLATFORM(IOS) > if (!m_playbackTarget || !m_playbackTarget->hasActiveRoute()) > return false; > +#endif I don't understand this change. (In reply to comment #11) > Comment on attachment 277763 [details] > Revised patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277763&action=review > > > Source/WebCore/html/MediaElementSession.cpp:364 > > +#if !PLATFORM(IOS) > > if (!m_playbackTarget || !m_playbackTarget->hasActiveRoute()) > > return false; > > +#endif > > I don't understand this change. m_playbackTarget isn't relevant on iOS. Comment on attachment 277763 [details] Revised patch. Rejecting attachment 277763 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 277763, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://webkit-queues.webkit.org/results/1242119 Committed r200273: https://trac.webkit.org/r200273 |