Bug 156493

Summary: PolymorphicAccess::regenerate() shouldn't have to clone non-generated AccessCases
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2016-04-11 21:58:35 PDT
...
Attachments
the patch (4.26 KB, patch)
2016-04-12 15:04 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-04-12 15:04:47 PDT
Created attachment 276283 [details] the patch
Geoffrey Garen
Comment 2 2016-04-12 16:08:56 PDT
Comment on attachment 276283 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=276283&action=review r=me > Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:1571 > + found = true; > + break; Can we just return here?
Filip Pizlo
Comment 3 2016-04-13 11:47:45 PDT
(In reply to comment #2) > Comment on attachment 276283 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=276283&action=review > > r=me > > > Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:1571 > > + found = true; > > + break; > > Can we just return here? Yup, good point.
Filip Pizlo
Comment 4 2016-04-13 12:05:01 PDT
Landed in http://trac.webkit.org/changeset/199508
Note You need to log in before you can comment on or make changes to this bug.