Bug 156488

Summary: putImageData needs to premultiply input
Product: WebKit Reporter: Dean Jackson <dino>
Component: CanvasAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, sabouhallawa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zalan: review+

Description Dean Jackson 2016-04-11 19:43:52 PDT 
I made a mistake in r187534, where I updated putImageData to use the Accelerate framework. The iOS path accidentally unpremultiplied the incoming data, rather than premultiplying it.
Comment 1 Radar WebKit Bug Importer 2016-04-11 19:44:17 PDT 
<rdar://problem/25672675>
Comment 2 Dean Jackson 2016-04-11 19:45:11 PDT 
<rdar://problem/23119884>
Comment 3 Dean Jackson 2016-04-11 19:49:08 PDT 
Created attachment 276201 [details]
Patch
Comment 4 Jon Lee 2016-04-11 19:51:28 PDT 
What's the impact on the Animometer Images test?
Comment 5 Dean Jackson 2016-04-11 19:52:36 PDT 
(In reply to comment #4)
> What's the impact on the Animometer Images test?

Should be zero. We're still doing the same sets of operations, just multiplying rather than dividing. And this is iOS only.
Comment 6 Dean Jackson 2016-04-11 19:57:26 PDT 
Committed r199330: <http://trac.webkit.org/changeset/199330>