Bug 15642 – Report build errors to users on Windows

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Kevin Ollivier]

Currently, the build-webkit script leaves it up to the build tool to report errors, but since MSVC doesn't do this, no actual error message is reported and the build looks as if it succeeds. This patch changes it so that the build script reports that a build error has occurred, and explains where to find build errors on MSVC.

[Kevin Ollivier]

Created attachment 16821 [details]
Patch to report build errors on Windows

[Adam Roben (:aroben)]

Comment on attachment 16821 [details]
Patch to report build errors on Windows

+    if (1 || exitStatus($result)) {

I assume the "1 ||" was for debugging purposes? In any case I think it should be removed.

+sub getRelativeScriptsDir()

I don't think the "get" prefix is helpful here.

It would be great at some point to enhance the script to look through the build logs to figure out which project(s) failed and point the user at those logs more specifically.

I'll r+ once the above two issues are fixed.

[Kevin Ollivier]

Created attachment 16891 [details]
Fixed version of patch

Sorry, yes, the 1 was a leftover from debugging that I overlooked. Fixed now. This version also makes relativeScriptsDir consistent with other function names in webkitdirs.pm. I agree with the suggestion of tracking down which projects failed using the build logs and would like to see it as well, but don't have time to implement that feature ATM so it is not in this version.

[Adam Roben (:aroben)]

Comment on attachment 16891 [details]
Fixed version of patch

r=me

Thanks! This will be a great help.

[Mark Rowe (bdash)]

Landed in r27348.