Summary: | Debugger may dereference m_currentCallFrame even after the VM has gone idle | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, joepeck, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Saam Barati
2016-04-08 12:26:20 PDT
Created attachment 276026 [details]
patch
Comment on attachment 276026 [details]
patch
r=me.
Would be better if you have a test. Or at least document why it's not possible to test. Or file a bug to land a test later.
(In reply to comment #2) > Comment on attachment 276026 [details] > patch > > r=me. > > Would be better if you have a test. Or at least document why it's not > possible to test. Or file a bug to land a test later. Thanks for the review. I opened a bug to investigate if it's doable to write a test. https://bugs.webkit.org/show_bug.cgi?id=156417 Comment on attachment 276026 [details] patch Clearing flags on attachment: 276026 Committed r199249: <http://trac.webkit.org/changeset/199249> All reviewed patches have been landed. Closing bug. |