Bug 156395

Summary: [EFL] alert box is not displayed
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Hunseop Jeong <hs85.jeong>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, hs85.jeong, lucas.de.marchi
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Jinwoo Song 2016-04-07 23:31:06 PDT
Alert box is not displayed with following error message.

./MiniBrowser http://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_alert
ERR<2090>:ecore lib/ecore/ecore_main.c:1283 ecore_main_loop_begin() Running ecore_main_loop_begin() inside an existing main loop
Comment 1 Hunseop Jeong 2016-09-22 01:24:50 PDT
Created attachment 289536 [details]
Patch
Comment 2 Gyuyoung Kim 2016-09-22 02:07:35 PDT
Comment on attachment 289536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289536&action=review

> Tools/MiniBrowser/efl/main.c:1427
> +   

Remove unnecessary spaces.

> Tools/MiniBrowser/efl/main.c:1429
> +   

ditto.
Comment 3 Hunseop Jeong 2016-09-22 04:31:40 PDT
Created attachment 289546 [details]
Patch
Comment 4 Hunseop Jeong 2016-09-22 17:52:24 PDT
Created attachment 289637 [details]
Patch
Comment 5 Gyuyoung Kim 2016-09-22 17:57:08 PDT
Comment on attachment 289637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289637&action=review

LGTM with nits.

> Tools/MiniBrowser/efl/main.c:1414
> +    

Unnecessary spaces.

> Tools/MiniBrowser/efl/main.c:1441
> +   

Unnecessary spaces.

> Tools/MiniBrowser/efl/main.c:1471
> +   

Unnecessary spaces.
Comment 6 Hunseop Jeong 2016-09-22 19:34:21 PDT
Created attachment 289651 [details]
Patch
Comment 7 WebKit Commit Bot 2016-09-22 21:18:18 PDT
Comment on attachment 289651 [details]
Patch

Clearing flags on attachment: 289651

Committed r206290: <http://trac.webkit.org/changeset/206290>
Comment 8 WebKit Commit Bot 2016-09-22 21:18:22 PDT
All reviewed patches have been landed.  Closing bug.