Bug 156346

Summary:

[WebIDL] Add support for [EnabledAtRuntime] attributes on non-global objects

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cgarcia, commit-queue, esprehn+autocc, ggaren, kondapallykalyan, rniwa, sam, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2016-04-07 10:50:22 PDT

Add support for [EnabledAtRuntime] attributes on non-global objects by using the same approach as for [EnabledAtRuntime] operations.

Comment 1 Chris Dumez 2016-04-07 10:58:29 PDT

Created attachment 275898 [details]
Patch

Comment 2 WebKit Commit Bot 2016-04-07 10:59:27 PDT

Attachment 275898 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1330:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:2540:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Commit Bot 2016-04-07 14:56:58 PDT

Comment on attachment 275898 [details]
Patch

Clearing flags on attachment: 275898

Committed r199188: <http://trac.webkit.org/changeset/199188>

Comment 4 WebKit Commit Bot 2016-04-07 14:57:04 PDT

All reviewed patches have been landed.  Closing bug.