Bug 156332

Summary: [CMake][Win] Generating autoversion.h of WebKitGUID is triggered again and again
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2016-04-07 01:15:28 PDT
[CMake][Win] Generating autoversion.h of WebKitGUID is triggered again and again In Source/WebKit/PlatformWin.cmake: > add_custom_command( > OUTPUT ${DERIVED_SOURCES_WEBKIT_DIR}/autoversion.h > WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} > COMMAND ${PERL_EXECUTABLE} ${WEBKIT_LIBRARIES_DIR}/tools/scripts/auto-version.pl ${DERIVED_SOURCES_WEBKIT_DIR} > VERBATIM) The output path is not ${DERIVED_SOURCES_WEBKIT_DIR}/autoversion.h, but ${DERIVED_SOURCES_WEBKIT_DIR}/include/autoversion.h. Then Visual Studio thinks the output file deos not exist yet and trigger the command.
Attachments
Patch (1.54 KB, patch)
2016-04-07 01:33 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2016-04-07 01:33:45 PDT
Created attachment 275870 [details] Patch
Brent Fulgham
Comment 2 2016-04-07 08:46:10 PDT
Comment on attachment 275870 [details] Patch Oh! Thank you for noticing this. r=me.
Alex Christensen
Comment 3 2016-04-07 09:03:47 PDT
Wow, I looked at this over and over again and couldn't see the problem. Thanks!
WebKit Commit Bot
Comment 4 2016-04-07 09:37:42 PDT
Comment on attachment 275870 [details] Patch Clearing flags on attachment: 275870 Committed r199158: <http://trac.webkit.org/changeset/199158>
WebKit Commit Bot
Comment 5 2016-04-07 09:37:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.