| Summary: | [CMake][Win] Generating autoversion.h of WebKitGUID is triggered again and again | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, bfulgham, cdumez, commit-queue, darin | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 275870 [details]
Patch
Comment on attachment 275870 [details]
Patch
Oh! Thank you for noticing this. r=me.
Wow, I looked at this over and over again and couldn't see the problem. Thanks! Comment on attachment 275870 [details] Patch Clearing flags on attachment: 275870 Committed r199158: <http://trac.webkit.org/changeset/199158> All reviewed patches have been landed. Closing bug. |
[CMake][Win] Generating autoversion.h of WebKitGUID is triggered again and again In Source/WebKit/PlatformWin.cmake: > add_custom_command( > OUTPUT ${DERIVED_SOURCES_WEBKIT_DIR}/autoversion.h > WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} > COMMAND ${PERL_EXECUTABLE} ${WEBKIT_LIBRARIES_DIR}/tools/scripts/auto-version.pl ${DERIVED_SOURCES_WEBKIT_DIR} > VERBATIM) The output path is not ${DERIVED_SOURCES_WEBKIT_DIR}/autoversion.h, but ${DERIVED_SOURCES_WEBKIT_DIR}/include/autoversion.h. Then Visual Studio thinks the output file deos not exist yet and trigger the command.