Bug 156330

Summary: Rationalize the handling of PutById transitions a bit
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
none
the patch mark.lam: review+

Description Filip Pizlo 2016-04-06 21:37:12 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-04-06 21:37:43 PDT 
Created attachment 275862 [details]
work in progress
Comment 2 Filip Pizlo 2016-04-07 10:33:11 PDT 
Created attachment 275894 [details]
the patch
Comment 3 Mark Lam 2016-04-07 10:55:59 PDT 
Comment on attachment 275894 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275894&action=review

r=me with fix.

> Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:1050
> -        if (newStructure()->outOfLineCapacity() != structure()->outOfLineCapacity()
> -            && structure()->outOfLineCapacity())
> +        if (allocating)

This should be "if (reallocating)".
Comment 4 Filip Pizlo 2016-04-07 10:58:10 PDT 
(In reply to comment #3)
> Comment on attachment 275894 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=275894&action=review
> 
> r=me with fix.
> 
> > Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:1050
> > -        if (newStructure()->outOfLineCapacity() != structure()->outOfLineCapacity()
> > -            && structure()->outOfLineCapacity())
> > +        if (allocating)
> 
> This should be "if (reallocating)".

Actually, it needs to be "allocating" because we now use scratchGPR3 in the store barrier slow path, which happens when we're either allocating or reallocating.
Comment 5 Mark Lam 2016-04-07 10:58:50 PDT 
Comment on attachment 275894 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275894&action=review

>>> Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:1050
>>> +        if (allocating)
>> 
>> This should be "if (reallocating)".
> 
> Actually, it needs to be "allocating" because we now use scratchGPR3 in the store barrier slow path, which happens when we're either allocating or reallocating.

Oh, I missed that.  LGTM.
Comment 6 Filip Pizlo 2016-04-07 11:17:25 PDT 
Landed in http://trac.webkit.org/changeset/199162