Bug 15632

Summary: js1_5/Array/array-001.js test failing
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Major CC: eric
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch with change log and tests ggaren: review+

Darin Adler
Reported 2007-10-22 16:36:03 PDT
I figured out why this test is failing, it's a problem with fractional array indices. Not sure why this didn't fail when I did my pre-submission tests. I have a fix almost done.
Attachments
patch with change log and tests (9.94 KB, patch)
2007-10-22 16:36 PDT, Darin Adler 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2007-10-22 16:36:55 PDT
Created attachment 16811 [details] patch with change log and tests
Geoffrey Garen
Comment 2 2007-10-22 16:43:23 PDT
Comment on attachment 16811 [details] patch with change log and tests r=me
Darin Adler
Comment 3 2007-10-22 16:47:11 PDT
Committed revision 26899.
Eric Seidel (no email)
Comment 4 2007-10-22 16:48:56 PDT
I'm not sure the float/double variants are actually any benefit now that this has to do the blind-assignment and equality check. I bet the compiler was previously optimizing out the float to double back to int conversion into just a float to int conversion... but we'd have to look at the assembler to be sure.
Darin Adler
Comment 5 2007-10-22 17:57:52 PDT
(In reply to comment #4) > I'm not sure the float/double variants are actually any benefit now that this > has to do the blind-assignment and equality check. I bet the compiler was > previously optimizing out the float to double back to int conversion into just > a float to int conversion... but we'd have to look at the assembler to be sure. I'm almost sure it was not. I saw conversion to float in the assembler. But please investigate!
Note You need to log in before you can comment on or make changes to this bug.