| Summary: | window.CSS should be a constructor with static functions | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, rniwa, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Sam Weinig
2016-04-06 11:08:26 PDT
Created attachment 275785 [details]
Patch
Comment on attachment 275785 [details] Patch Attachment 275785 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1110325 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275798 [details]
Archive of layout-test-results from ews102 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 275785 [details] Patch Attachment 275785 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1110328 New failing tests: js/dom/global-constructors-attributes.html Created attachment 275801 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 275785 [details]
Patch
r=me but please make EWS happy before landing.
Created attachment 275803 [details]
Patch
Comment on attachment 275803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275803&action=review > LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt:126 > +PASS Object.getOwnPropertyDescriptor(global, 'CSS').value is CSS You will likely need to update these as well: LayoutTests//js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/efl/js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/gtk/js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt LayoutTests//platform/win/js/dom/global-constructors-attributes-expected.txt Created attachment 275806 [details]
Patch
Created attachment 275807 [details]
Patch
Committed r199112: <http://trac.webkit.org/changeset/199112> |